Fix for issue #417 #633
Merged
Fix for issue #417 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. Can you please indent the lines correctly which were in the then-block of the removed if-condition? Apart from that, this can be merged in from my point of view. |
|
Hm, would like to merge it, but github says it has conflicts. Can you have a look into this, please? |
|
Probably ChangeLog-conflicts... |
|
By the way, when merging the ChangeLog (if that is the one with the conflict), note that the entry starting |
nivieru
force-pushed
the
fix-for-issue-#417
branch
from
a93d01d to
c05fb53
Compare
|
Ok, I think it should be fine now |
oscargus
added a commit
that referenced
this pull request
Jan 4, 2016
|
I thought I'd give it a try to see how merging works. :-) Hope I didn't break anything... |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed checks that prevented the table from being updated when switching between groups.